Repository navigation
Conversation
actions/checkout writes GITHUB_TOKEN into .git/config by default, so any later build step, script, or compromised dependency could read it. These jobs never push, so drop the persisted credential. spm-release.yml keeps it because it pushes the SPM tag. test-vcpkg.yml also gains an explicit read-only permissions block so it no longer inherits the repository default. Files changed: .github/workflows/build-android.yml .github/workflows/build-ios-mac.yml .github/workflows/build-posix-latest.yml .github/workflows/build-ubuntu-2204.yml .github/workflows/build-windows-vs2022.yaml .github/workflows/codeql-analysis.yml .github/workflows/deploy-docs-pages.yml .github/workflows/memory-leak-analysis.yml .github/workflows/spellcheck.yml .github/workflows/test-embedding.yml .github/workflows/test-vcpkg.yml .github/workflows/test-win-latest.yml Co-authored-by: Copilot <[email protected]> Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
Dependabot clones with --recurse-submodules and cannot access the private cpp_client_telemetry_modules repository. Git then aborts the submodule update, leaving third_party/googletest fetched but not checked out. That dirty submodule makes every Dependabot github_actions update fail when it tries to commit. Setting update = none for lib/modules lets recursive clones without access succeed; authorized users fetch it explicitly with git submodule update --init --checkout lib/modules. Files changed: - .gitmodules - docs/building-with-vcpkg.md - docs/cpp-start-android.md - docs/cpp-start-ios.md - docs/cpp-start-linux.md - docs/cpp-start-macosx.md - docs/cpp-start-windows.md - docs/maintainer-onboarding.md - docs/xamarin.md Co-authored-by: Copilot <[email protected]> Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
Include the integer type used by the standalone public header, and use an atomic shell noclobber lock in the runner test fixture so concurrent children are distinguished on Ubuntu 26.04. Files: lib/include/public/ICdsFactory.hpp, tests/build-runner-tests.py Co-authored-by: Copilot <[email protected]> Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
Stop dumping environment variables, fail CodeQL and spellcheck when checkout fails, and remove a sanitizer warning suppression that the pinned module no longer needs. Files: .github/workflows/build-android.yml, .github/workflows/codeql-analysis.yml, .github/workflows/spellcheck.yml, lib/CMakeLists.txt. Co-authored-by: Copilot <[email protected]> Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
bmehta001
enabled auto-merge (squash)
November 20, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Harden CI against credential exposure and fix Dependabot's recursive-clone failures caused by the private modules submodule.
Changes
test-vcpkg.ymltocontents: read..gitmoduleslib/modulestoupdate = noneso anonymous recursive clones complete; documentgit submodule update --init --checkout lib/modulesfor authorized users.ICdsFactory.hppand use atomic shell noclobber in the runner test fixture. Both fixes are also isolated in Fix public-header and runner-contract CI failures #1566 to unblock the private SDK pin first.-Wreordersuppression: the SDK-pinned module already initializes those fields in declaration order.Validation
-Werror=reorder.BasicFuncTests.killSwitchWorks; this PR does not change those filters.Coordination
Merge #1566 first, update the private CI's old SDK pin to an approved merged commit and validate it, then merge microsoft/cpp_client_telemetry_modules#375 before this PR. This preserves the private Android AAR when submodule initialization changes.
Both repositories use read-only default workflow tokens and disable Actions PR creation/approval. Existing credentials, including any historical vcpkg publishing token, should be revoked by their owners if still active and no longer needed; the private legacy
GIT_PULL_TOKENmust not be deleted until its remaining branch consumers are migrated.